View mode had a canvas and an empty left dock. It gets the two surfaces that make many frames navigable, and the bar stops going quiet while work is in flight. The dock swap. One left dock with two heads and two bodies, swapped by mode, rather than two docks fighting over the same edge. `covers()` in the safe-inset calculation moves from raw open flags to `isVisible`, which fixes a fit that sat off-centre whenever the inspector was mode-gated away — the flag said open, the panel was not on screen. `repinTranscript()` defers a scroll fix to the next frame, because a `display:none` transcript reports zero metrics and the pin was computing against nothing. The frame list. Rows with a device glyph, inline rename, a row menu and an add menu; click to centre, double-click to fit; drag to restack through dnd-kit with a drop-line indicator, and keyboard ↑↓ on the grip. That needs `POINTER_ONLY` sensors: a `feedback: "none"` draggable cannot keyboard-drag anyway, and leaving the keyboard sensor registered started a phantom drag that also ate Tab. Rows rebuild on a `shape` key, so panning the canvas does not rebuild the list. The minimap. A fixed-size card of rectangles, not thumbnails — thumbnails of live iframes cost a paint per frame per move and tell you nothing a rectangle does not. Bounds are the frames unioned with the visible rect. Dragging pans against a projection snapshot frozen at pointerdown plus the grab offset, so the projection cannot shift under the gesture driving it. No close button: the last one was undiscoverable to restore. Apply, Discard and the job chip. `pendingCount()` now includes `structureSet`, which is a real fix rather than a tidy-up — a delete rendered a chip and blocked the surface toggle while never revealing the composer, so there was no way to send it. Reveal fires on a rise in `pendingCount` against a `pendingSeen` watermark instead of on "non-zero", so a dock the user deliberately closed stays closed. Discard all and New chat get a confirm-before-destroy two-step anchored on the button that triggered them. The job chip lives in its own `bar-job-host` so mode-gating and `awaiting`-gating stop clobbering each other, and `reportOffscreenTurn` offers a "Show" action when a turn finishes with the transcript hidden. Connection resilience. `submit()` refuses with an error toast when the socket is closed, rather than entering `awaiting` for a message that was never sent. On `hello`, `reconcileAwaiting` walks the server's jobs and `releaseAwaiting` closes an orphaned turn with an error bubble pointing at Past chats. It deliberately keeps pending visual deltas: the connection dropped, the user's unsent work did not. Also `shell-app.ts`: `pruneFrameUnsubs()` disposes the layout subscriptions of deleted frames. Each closure was pinning a dead frame's `window`. All six style modules land together so the stylesheet stays internally consistent in one commit. `pop.css.ts`'s new `.tip*` rules in particular arrive alongside the deletion of the old `.tip` block from `docks.css.ts`; split, one of those two commits has tooltips styled twice and the other has them not at all.
342 lines
18 KiB
TypeScript
342 lines
18 KiB
TypeScript
import { PREFIX } from "../dom";
|
|
import { TIP_MAX_W, Z_POP } from "./const";
|
|
|
|
/**
|
|
* The popover layer: the host, the shared shell, and the menu shape.
|
|
*
|
|
* The host is the overlay root's last child and covers it exactly, so a shell's
|
|
* `position: absolute` coordinates are already screen coordinates and
|
|
* `placePopover`'s offset-parent conversion collapses to the identity.
|
|
*
|
|
* The colour picker's own internals live in `controls.css.ts` next to the swatch
|
|
* they belong to; only the shell chrome is here.
|
|
*/
|
|
export const css = `
|
|
.${PREFIX}-pop-host {
|
|
position: absolute; inset: 0; z-index: ${Z_POP}; pointer-events: none;
|
|
}
|
|
/* The tooltip. Here rather than beside the docks it mostly labels, because
|
|
\`Tooltips\` mounts it into the host above and its neighbours are the shells
|
|
below it.
|
|
|
|
\`z-index: 1\`, and not the global \`Z\`: the host is a stacking context of its
|
|
own, so the global scale means nothing inside it. What this orders is the tip
|
|
against its *siblings* — the \`.pop\` shells, which carry no z-index and are all
|
|
appended after the tip, which is created once when the overlay mounts. Drop
|
|
the number and DOM order takes over: the tip paints under every popover ever
|
|
opened, which is how it reads on a control inside the colour picker.
|
|
|
|
It wraps, and that is the shape of the whole rule. Most tips are one short
|
|
line, but a handful carry values the editor did not author — a font stack, a
|
|
stylesheet URL, a review comment body — and for those the tip *is* the
|
|
untruncated view of a field that already truncated. Ellipsing them throws
|
|
away the only thing they were opened for.
|
|
|
|
This used to say \`white-space: nowrap\` alongside the same width cap and no
|
|
overflow rule at all. Those cannot both hold: the text laid out at its full
|
|
intrinsic width while the border, background and shadow painted at the cap, so
|
|
from about 45 characters up the label sat outside its own box. It also made
|
|
\`offsetWidth\` report the cap rather than the painted width, so the centring in
|
|
\`Tooltips.place\` and its dock clamp were both computed from a number that was
|
|
never true of anything on screen. */
|
|
.${PREFIX}-tip {
|
|
position: absolute; z-index: 1; pointer-events: none;
|
|
display: flex; align-items: baseline; gap: 6px;
|
|
width: max-content; max-width: ${TIP_MAX_W}px; padding: 4px 8px;
|
|
background: var(--ap-surface-selected); color: var(--ap-text-primary);
|
|
border: 1px solid var(--ap-border-default); border-radius: var(--ap-radius-xs);
|
|
box-shadow: var(--ap-elevation-floating);
|
|
font-family: var(--ap-font-sans); font-size: var(--ap-font-size-body); line-height: 1.5;
|
|
}
|
|
/* Three lines, then an ellipsis. A tip is a label and not a document, and the
|
|
interpolated ones have no length bound at all — a comment body is whatever
|
|
somebody typed into it.
|
|
|
|
\`overflow-wrap: anywhere\` rather than \`break-word\` is for the values with no
|
|
spaces to break at, a stylesheet URL being the one that actually turns up:
|
|
only \`anywhere\` lowers the min-content width, so the box settles at
|
|
\`max-width\` instead of being pushed past it by a single unbreakable token. */
|
|
.${PREFIX}-tip-text {
|
|
min-width: 0;
|
|
display: -webkit-box; -webkit-box-orient: vertical; -webkit-line-clamp: 3;
|
|
overflow: hidden; overflow-wrap: anywhere;
|
|
}
|
|
/* The chord never wraps and never shrinks. It is the one part of a tooltip that
|
|
is unreadable if it breaks, so the \`min-width: 0\` above makes the *text* the
|
|
item that gives way — the container stays \`flex-wrap: nowrap\`, which is what
|
|
keeps the chip on the first line beside a wrapped tip instead of orphaning it
|
|
onto a line of its own. \`baseline\` on the container is what sits it on that
|
|
first line rather than halfway down the block, and it is also what lines
|
|
JetBrains Mono up with Inter at the same size, which \`center\` never did. */
|
|
.${PREFIX}-tip-key {
|
|
flex: 0 0 auto; white-space: nowrap;
|
|
font-family: var(--ap-font-mono); color: var(--ap-text-tertiary);
|
|
}
|
|
/* The shell is the scroller, because the shell is what carries the cap.
|
|
|
|
\`placePopover\` measures the content and writes a \`max-height\` *here* — and a
|
|
max-height on a box with no overflow does not scroll. It just shortens the
|
|
painted box and lets the rest of the content run out through the radius, over
|
|
the page, with no background under it. A long menu rendered its first dozen
|
|
rows on the panel and the rest on the canvas.
|
|
|
|
\`.fc-menu\` — the canvas's own client of the same placement code — has always
|
|
carried \`overflow-y: auto\`. This rule was written from it and kept
|
|
\`overscroll-behavior\`, which is only meaningful on a scroller, while dropping
|
|
the property that made it one.
|
|
|
|
\`overflow-x: hidden\` rather than auto: nothing here should ever be wider than
|
|
its own shell (see \`matchAnchorWidth\`), and a horizontal scrollbar under a
|
|
menu is a bug report rather than an affordance. Note this also makes the shell
|
|
a clipping box, so a popover that hangs a decoration outside its content will
|
|
lose it — every current one keeps its knobs and chits inside the 8px padding. */
|
|
.${PREFIX}-pop {
|
|
position: absolute; pointer-events: auto;
|
|
background: var(--ap-surface-panel);
|
|
border: 1px solid var(--ap-border-default);
|
|
border-radius: var(--ap-radius-md);
|
|
box-shadow: var(--ap-elevation-floating);
|
|
overflow-x: hidden; overflow-y: auto;
|
|
overscroll-behavior: contain;
|
|
}
|
|
|
|
/* Menu. Mirrors \`.fc-menu-item\` rather than sharing it: the canvas keeps its
|
|
own \`.fc-menu*\` for the device and add-frame menus, which are placed against
|
|
world-space geometry on every pan and re-anchor themselves, so they never
|
|
came through this host. Two shapes that look alike but answer to different
|
|
placement code are better apart than accidentally coupled. */
|
|
/* \`overflow-y\` here is now redundant for a plain menu — the shell hits its cap
|
|
first — but it is load-bearing for \`.token-list\`, which composes this class
|
|
and takes its scrolling from it. Do not tidy it away. */
|
|
.${PREFIX}-pop-menu {
|
|
display: flex; flex-direction: column;
|
|
padding: 4px; min-width: 150px; overflow-y: auto;
|
|
}
|
|
.${PREFIX}-pop-item {
|
|
display: flex; align-items: center; justify-content: space-between; gap: 12px;
|
|
padding: 5px 8px; border: 0; border-radius: var(--ap-radius-xs);
|
|
background: transparent; cursor: pointer; text-align: left;
|
|
font-family: var(--ap-font-sans); font-size: var(--ap-font-size-label);
|
|
color: var(--ap-text-primary);
|
|
}
|
|
.${PREFIX}-pop-item:hover { background: var(--ap-surface-active); }
|
|
/* The selected value and the keyboard cursor are different states — you arrow
|
|
past the current value on the way to another one, and a menu that moves its
|
|
checkmark with the arrow keys is lying about what is set. */
|
|
.${PREFIX}-pop-item-on { color: var(--ap-primary); }
|
|
.${PREFIX}-pop-item[data-pop-active] {
|
|
background: var(--ap-surface-active); outline: none;
|
|
}
|
|
.${PREFIX}-pop-item:focus-visible {
|
|
outline: 1px solid var(--ap-border-focus); outline-offset: -1px;
|
|
}
|
|
.${PREFIX}-pop-item-hint {
|
|
font-family: var(--ap-font-mono); font-size: var(--ap-font-size-caption); opacity: .5;
|
|
}
|
|
.${PREFIX}-pop-sep { height: 1px; margin: 4px 2px; background: var(--ap-border-default); }
|
|
/* Group heading. Same mono eyebrow as the inspector's section headers, so a
|
|
grouped menu reads as part of the same system. */
|
|
.${PREFIX}-pop-head {
|
|
padding: 6px 8px 2px; font-family: var(--ap-font-mono); text-transform: uppercase;
|
|
font-size: var(--ap-font-size-micro); letter-spacing: .6px; color: var(--ap-text-tertiary);
|
|
}
|
|
/* ---- Collapsible group -------------------------------------------------- */
|
|
|
|
/* The long-list answer, next to \`pop-head\`'s short-list one. Written to the same
|
|
measures as \`fc-dgroup\` in \`canvas.css.ts\` on purpose: the device list appears
|
|
in both menu systems, and two accordions over the same twenty-two rows must
|
|
not be visibly different objects. */
|
|
.${PREFIX}-pop-group { display: flex; flex-direction: column; }
|
|
.${PREFIX}-pop-group + .${PREFIX}-pop-group {
|
|
margin-top: 4px; padding-top: 4px;
|
|
border-top: 1px solid var(--ap-border-default);
|
|
}
|
|
/* Sentence case and body type, not \`pop-head\`'s uppercase mono: these are
|
|
section headers in a list you are reading, not the menu's own title. */
|
|
.${PREFIX}-pop-group-head {
|
|
display: flex; align-items: center; gap: 6px; width: 100%;
|
|
padding: 5px 8px; border: 0; border-radius: var(--ap-radius-xs);
|
|
background: transparent; cursor: pointer; text-align: left;
|
|
font-family: var(--ap-font-sans); font-size: var(--ap-font-size-label);
|
|
color: var(--ap-text-primary);
|
|
}
|
|
.${PREFIX}-pop-group-head:hover { background: var(--ap-surface-active); }
|
|
/* Rotating \`chev-right\` a quarter turn reproduces \`chev-down\` exactly — the set
|
|
draws them as one path at two rotations — so one glyph serves both states.
|
|
Driven from \`aria-expanded\`, which is where the state already lives. */
|
|
.${PREFIX}-pop-group-head .${PREFIX}-ic { flex: 0 0 16px; opacity: .5; }
|
|
.${PREFIX}-pop-group-head[aria-expanded="true"] .${PREFIX}-ic { transform: rotate(90deg); }
|
|
/* 8px padding + 16px glyph + 6px gap, so a group's name and every row under it
|
|
share one left edge and the triangle hangs in a gutter of its own. Getting
|
|
this wrong is what makes an accordion read as two unrelated lists rather than
|
|
a tree. */
|
|
.${PREFIX}-pop-group-body .${PREFIX}-pop-item { padding-left: 30px; }
|
|
|
|
.${PREFIX}-pop-item-main { display: inline-flex; align-items: center; gap: var(--ap-space-xs); min-width: 0; }
|
|
.${PREFIX}-pop-item-main { --${PREFIX}-ic-tone: var(--ap-icon-secondary); }
|
|
.${PREFIX}-pop-item-main .${PREFIX}-ic { flex: 0 0 auto; }
|
|
.${PREFIX}-pop-item[aria-disabled="true"] { opacity: .4; cursor: default; }
|
|
.${PREFIX}-pop-item[aria-disabled="true"]:hover { background: transparent; }
|
|
|
|
/* ---- Review comment box ------------------------------------------------- */
|
|
/* Anchored to the diff it is about, rather than prefilling the composer: the
|
|
whole value of a comment is that it points at specific lines. */
|
|
.${PREFIX}-pop-comment { padding: var(--ap-space-xs); }
|
|
.${PREFIX}-comment-pop { display: flex; flex-direction: column; gap: 6px; width: 280px; }
|
|
.${PREFIX}-comment-where {
|
|
display: flex; align-items: center; gap: var(--ap-space-xs);
|
|
font-family: var(--ap-font-mono); font-size: var(--ap-font-size-caption);
|
|
color: var(--ap-text-tertiary);
|
|
}
|
|
.${PREFIX}-comment-where { --${PREFIX}-ic-tone: var(--ap-primary); }
|
|
.${PREFIX}-comment-input {
|
|
width: 100%; resize: vertical; min-height: 56px;
|
|
font-family: var(--ap-font-sans); font-size: var(--ap-font-size-label);
|
|
line-height: 1.45; color: var(--ap-text-primary);
|
|
background: var(--ap-input-bg); border: 1px solid var(--ap-input-border);
|
|
border-radius: var(--ap-radius-sm); padding: 6px 8px;
|
|
}
|
|
.${PREFIX}-comment-input:focus { outline: none; border-color: var(--ap-input-focus-border); }
|
|
.${PREFIX}-comment-actions { display: flex; align-items: center; justify-content: space-between; gap: var(--ap-space-xs); }
|
|
.${PREFIX}-comment-hint { font-family: var(--ap-font-mono); font-size: var(--ap-font-size-caption); color: var(--ap-text-tertiary); }
|
|
|
|
/* ---- A form in a popover ------------------------------------------------ */
|
|
/* The "advanced settings" shape: the two or three properties you set once
|
|
and then forget, kept out of the section's everyday height. Same labelled
|
|
rows as the panel, so it reads as the same system rather than a dialog. */
|
|
.${PREFIX}-pop-form {
|
|
display: flex; flex-direction: column;
|
|
padding: var(--ap-space-sm); min-width: 236px;
|
|
}
|
|
.${PREFIX}-pop-form .${PREFIX}-row-label { flex: 0 0 60px; }
|
|
/* The honest footnote. Quiet, and wrapped rather than truncated — it is the
|
|
only place the panel explains what CSS cannot express, so it has to be
|
|
readable rather than tidy. */
|
|
.${PREFIX}-pop-note {
|
|
margin-top: var(--ap-control-row-gap);
|
|
padding-top: var(--ap-control-row-gap);
|
|
border-top: 1px solid var(--ap-border-default);
|
|
font-family: var(--ap-font-sans); font-size: var(--ap-font-size-caption);
|
|
line-height: 1.45; color: var(--ap-text-tertiary);
|
|
}
|
|
/* A control that exists to name something CSS will not do. Legible enough to
|
|
read, plainly inert. */
|
|
.${PREFIX}-pop-form [disabled],
|
|
.${PREFIX}-pop-form .${PREFIX}-ctl-input[disabled] {
|
|
cursor: default; opacity: .38;
|
|
}
|
|
|
|
/* ---- Design token picker ------------------------------------------------ */
|
|
/* A menu with a search field on top. Same width as .pop-form above — the panel
|
|
had grown three different popover widths (236, 240, 260) for three popovers
|
|
that all sit against the same 320px rail.
|
|
|
|
\`overflow: hidden\` is load-bearing, not tidiness. \`placePopover\` defaults to
|
|
\`scroll: true\` and writes a \`max-height\` measured from the shell as it stands
|
|
at open time — and this shell opens with an empty list, so that height was the
|
|
search field alone. Every row added afterwards overflowed a ~40px box that had
|
|
no \`overflow\` set, so the options painted *outside* the shell, over the page,
|
|
with no background under them; scrolling the inner list moved them back into
|
|
the painted strip, which is exactly what it looked like. The reposition after
|
|
each render fixes the height, and this makes the failure impossible rather
|
|
than merely fixed.
|
|
|
|
\`.pop\` is a scroller in its own right now, and this opts *out* of it: the
|
|
search field is pinned and only the list below it may move, which is the one
|
|
shape the shared shell cannot express. The shorthand here wins over \`.pop\`'s
|
|
two longhands at equal specificity by source order. */
|
|
.${PREFIX}-pop-token {
|
|
display: flex; flex-direction: column;
|
|
min-width: 236px; overflow: hidden;
|
|
}
|
|
.${PREFIX}-token-pick {
|
|
display: flex; flex-direction: column; min-width: 0; min-height: 0;
|
|
}
|
|
|
|
/* ---- Colour picker ------------------------------------------------------ */
|
|
|
|
.${PREFIX}-pop-color { width: 232px; }
|
|
.${PREFIX}-pop-color-body { display: flex; flex-direction: column; gap: 8px; padding: 8px; }
|
|
|
|
/* Saturation / value. Three stacked gradients: white to transparent across,
|
|
black to transparent up, over the current hue. Same construction a design tool uses,
|
|
and it costs no canvas and no repaint beyond one custom property. */
|
|
.${PREFIX}-pop-sv {
|
|
position: relative; height: 140px; border-radius: var(--ap-radius-xs);
|
|
cursor: crosshair; touch-action: none;
|
|
background:
|
|
linear-gradient(to top, #000, transparent),
|
|
linear-gradient(to right, #fff, transparent),
|
|
var(--${PREFIX}-hue, #f00);
|
|
}
|
|
.${PREFIX}-pop-sv:focus-visible { outline: 1px solid var(--ap-border-focus); outline-offset: 2px; }
|
|
.${PREFIX}-pop-sv-knob {
|
|
position: absolute; width: 12px; height: 12px; margin: -6px 0 0 -6px;
|
|
border: 2px solid #fff; border-radius: var(--ap-radius-full);
|
|
box-shadow: 0 0 0 1px rgba(0,0,0,.35); pointer-events: none;
|
|
}
|
|
|
|
.${PREFIX}-pop-sliders { display: flex; flex-direction: column; gap: 8px; }
|
|
.${PREFIX}-pop-slider {
|
|
position: relative; height: 12px; border-radius: var(--ap-radius-full);
|
|
cursor: pointer; touch-action: none;
|
|
}
|
|
.${PREFIX}-pop-slider:focus-visible { outline: 1px solid var(--ap-border-focus); outline-offset: 2px; }
|
|
.${PREFIX}-pop-slider-hue {
|
|
background: linear-gradient(to right, #f00, #ff0, #0f0, #0ff, #00f, #f0f, #f00);
|
|
}
|
|
/* The alpha track is the checkerboard; the gradient to the current colour is a
|
|
child so it can be restyled without rebuilding the checker. */
|
|
.${PREFIX}-pop-slider-alpha {
|
|
background-image: var(--${PREFIX}-checker); background-size: 8px 8px;
|
|
}
|
|
.${PREFIX}-pop-slider-fill {
|
|
position: absolute; inset: 0; border-radius: inherit; pointer-events: none;
|
|
}
|
|
.${PREFIX}-pop-slider-knob {
|
|
position: absolute; top: 50%; width: 14px; height: 14px; margin: -7px 0 0 -7px;
|
|
background: #fff; border-radius: var(--ap-radius-full);
|
|
box-shadow: 0 0 0 1px rgba(0,0,0,.35); pointer-events: none;
|
|
}
|
|
|
|
.${PREFIX}-pop-row { display: flex; align-items: center; gap: 4px; }
|
|
.${PREFIX}-pop-fields { flex: 1 1 auto; min-width: 0; display: flex; gap: 2px; }
|
|
.${PREFIX}-pop-fields > * { flex: 1 1 0; min-width: 0; }
|
|
/* Wide enough for "100" plus the % suffix — at 58px the value clipped to "10",
|
|
which is a wrong number rather than a truncated one. */
|
|
.${PREFIX}-pop-row > .${PREFIX}-ctl-num { flex: 0 0 66px; padding-left: 6px; }
|
|
.${PREFIX}-pop-mode {
|
|
display: inline-flex; align-items: center; gap: 2px; flex: 0 0 auto;
|
|
height: var(--ap-control-height); padding: 0 2px 0 4px;
|
|
border: 0; cursor: pointer; background: transparent; color: var(--ap-text-secondary);
|
|
border-radius: var(--ap-radius-xs);
|
|
font-family: var(--ap-font-mono); font-size: var(--ap-font-size-caption);
|
|
transition: background var(--ap-motion-dur-micro) var(--ap-motion-ease);
|
|
}
|
|
.${PREFIX}-pop-mode:hover { background: var(--ap-surface-hover); color: var(--ap-text-primary); }
|
|
.${PREFIX}-pop-eyedrop {
|
|
flex: 0 0 auto; display: inline-flex; align-items: center; justify-content: center;
|
|
width: var(--ap-control-height); height: var(--ap-control-height);
|
|
padding: 0; border: 0; cursor: pointer; background: transparent;
|
|
border-radius: var(--ap-radius-xs); transition: background var(--ap-motion-dur-micro) var(--ap-motion-ease);
|
|
}
|
|
.${PREFIX}-pop-eyedrop:hover { background: var(--ap-surface-active); }
|
|
|
|
.${PREFIX}-pop-recents {
|
|
display: flex; align-items: center; flex-wrap: wrap; gap: 4px;
|
|
padding-top: 8px; border-top: 1px solid var(--ap-border-default);
|
|
}
|
|
.${PREFIX}-pop-recents:empty { display: none; }
|
|
.${PREFIX}-pop-recents-label {
|
|
flex: 0 0 100%;
|
|
font-family: var(--ap-font-mono); text-transform: uppercase;
|
|
font-size: var(--ap-font-size-caption); letter-spacing: .6px; opacity: .5;
|
|
}
|
|
.${PREFIX}-pop-recent {
|
|
width: 18px; height: 18px; flex: 0 0 auto; padding: 0; cursor: pointer;
|
|
background-size: 6px 6px; border-radius: var(--ap-radius-xs);
|
|
border: 1px solid var(--ap-border-default);
|
|
}
|
|
.${PREFIX}-pop-recent:hover { border-color: var(--ap-border-strong); }
|
|
.${PREFIX}-pop-recent:focus-visible { outline: 1px solid var(--ap-border-focus); outline-offset: 1px; }`;
|