Files
airship/.github/workflows/checks.yml
T
Nayan 5349607a38 ci: add a windows-latest leg and document Windows support
None of this was caught because nothing ever ran on Windows: every job in every
workflow was ubuntu-latest, and checks.yml did not even run on the PR that
reported it — only Vercel, which failed on fork authorization.

The check job now runs on both, fail-fast off so a Windows-only break still
reports the Linux result. `shell: bash` on the multi-line steps, since the
default shell there is pwsh, which shares none of that syntax; Git Bash ships
on the runner, so nothing needs rewriting. The two drift checks stay Linux-only
— they verify that a committed generated file matches its generator, which is a
property of the repo, not of the platform.

The new build step is unconditional and unscoped on purpose. `--affected` is
exactly what let these through: they lived in build scripts, so a PR touching
no affected package never ran them. A `pnpm clean` step guards the lane that
was broken in all eleven packages.

pnpm-workspace.yaml's release-age exclusions had drifted almost across the
board — turbo pinned at 2.10.1 against 2.10.9 in the lockfile, the Claude SDK
at 0.3.196 against 0.3.226, both codex packages a minor behind. A stale pin
does not fail loudly; it simply stops excluding anything, and the package falls
back under the gate. That is the silent optional-dep drop the file's own
esbuild comment documents, and every one of these ships per-platform packages
including win32.
2026-08-11 23:12:06 +05:30

125 lines
5.2 KiB
YAML

name: Checks
run-name: "Checks · ${{ github.head_ref || github.ref_name }}"
# The PR gate. Mirrors `make preflight` locally, with one deliberate difference:
# typecheck and test are scoped with `turbo --affected` against the PR base,
# which locally there is no base to diff against.
#
# Drafts are skipped. `ready_for_review` is in the trigger list so marking a PR
# ready re-runs this rather than leaving it permanently unchecked.
on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened, ready_for_review]
workflow_dispatch:
concurrency:
group: checks-${{ github.ref }}
cancel-in-progress: true
jobs:
check:
if: github.event_name == 'workflow_dispatch' || github.event.pull_request.draft == false
# Windows is a first-class target — the CLI installs from npm onto it — but
# it went untested until a contributor reported that a fresh clone could not
# build there at all. Three separate path/line-ending bugs had shipped
# invisibly because every lane ran on Linux only. fail-fast is off so a
# Windows-only break still reports the Linux result, and vice versa.
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v7
with:
# turbo --affected diffs against the PR base; it needs full history.
fetch-depth: 0
- uses: ./.github/actions/setup-workspace
- name: Lint (Biome via Ultracite)
run: pnpm lint
# `shell: bash` on every multi-line block below: the default shell on
# windows-latest is pwsh, which shares none of this syntax — no `[ -n … ]`,
# no `if ! cmd`, and `${VAR}` is not env expansion. Git Bash ships on the
# Windows runner, so pinning the shell is enough; nothing needs rewriting.
- name: Typecheck + test (affected)
shell: bash
env:
TURBO_SCM_BASE: ${{ github.event.pull_request.base.sha }}
run: |
if [ -n "${TURBO_SCM_BASE}" ]; then
pnpm turbo run typecheck test --affected
else
pnpm turbo run typecheck test
fi
# Unconditional and unscoped, unlike the step above. `--affected` is what
# let the Windows build bugs through: they lived in build scripts
# (check-css.mjs, vendor-assets.mjs, the gen.mjs front-matter readers), and
# a PR that touched none of the affected packages never ran them. This is
# the step that actually proves a clean checkout builds on both platforms.
- name: Build (every package)
run: pnpm build
# apps/cli/README.md is generated from the root README.md, and it is what
# npmjs.com renders for @airshiplabs/cli. Committed rather than built on
# demand so a clean checkout can publish without running the generator.
#
# Linux only, here and below: both of these check that a COMMITTED
# generated file matches what the generator emits. That is a property of
# the repo, not of the platform, so running it twice doubles the runtime
# and the flake surface for no extra signal.
- name: README is not stale
if: matrix.os == 'ubuntu-latest'
shell: bash
run: |
if ! node scripts/sync-readme.mjs --check; then
echo "::error file=apps/cli/README.md::The CLI README is stale. Run 'make readme' and commit the result."
exit 1
fi
# apps/web/src/routeTree.gen.ts is generated but committed, so it drifts.
# Regenerated by BUILDING, not by `tsr generate`: two things write this
# file and they disagree — the router CLI emits the tree alone, while the
# Start Vite plugin appends the `declare module` block that registers the
# router type for SSR. The build's output is the committed one. The build
# step above already wrote it; this only reads the result.
- name: Route tree is not stale
if: matrix.os == 'ubuntu-latest'
shell: bash
run: |
if ! git diff --quiet -- apps/web/src/routeTree.gen.ts; then
git diff --stat -- apps/web/src/routeTree.gen.ts
echo "::error file=apps/web/src/routeTree.gen.ts::The route tree is stale. Run 'make web:build' and commit the result."
exit 1
fi
# Last, because it deletes what everything above produced. Every workspace
# `clean` was `rm -rf` until this lane existed to catch it — a command that
# does not exist on Windows, so `pnpm clean` failed in all eleven packages.
- name: Clean (removes what the build produced)
run: pnpm clean
commitlint:
if: github.event_name == 'pull_request' && github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
with:
fetch-depth: 0
- uses: ./.github/actions/setup-workspace
# .husky/commit-msg runs the same rule, but a hook is only ever a
# courtesy — `--no-verify` skips it. This is the copy that counts.
- name: Conventional Commits
run: |
pnpm commitlint \
--from "${{ github.event.pull_request.base.sha }}" \
--to "${{ github.event.pull_request.head.sha }}" \
--verbose