erasmust-dotcom and Claude Opus 4.8
29a6954f91
fix(build): make ghost-node merge deterministic across process runs ( #1753 )
...
build_from_json's ghost-node merge iterated set(G.nodes()), so when two nodes
shared a (basename, label) key the "canonical" survivor was chosen by CPython's
per-process string-hash order — rebuilding the same extraction JSON in a fresh
process could pick a different survivor, silently changing which node id
represents a concept. That breaks any workflow persisting ids across a rebuild;
concretely it broke the cluster->relabel step (community membership referenced
an id that the second build merged away -> KeyError in report generation).
Two changes:
- Pass 1 and Pass 2 now iterate sorted(node_set), not set(node_set), the same
deterministic-order fix the edge loop below already uses on purpose.
- The #1257 ambiguity guard is extended to the case it did not cover: two
NON-AST nodes sharing a key but from DIFFERENT source files are distinct
concepts, not an AST ghost/canonical twin, so the key is marked ambiguous and
both survive rather than one arbitrarily merging away (data loss). A genuine
same-file duplicate (identical source_file) is not flagged and still
collapses to one node.
Reported with a precise root-cause, minimal repro, and real-world impact by
@erasmust-dotcom.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-09 23:32:54 +01:00
..
2026-07-09 00:32:21 +01:00
2026-04-04 18:52:44 +01:00
2026-05-02 12:54:08 +05:30
2026-05-22 13:22:51 +01:00
2026-06-27 23:57:39 +01:00
2026-07-05 11:41:18 +01:00
2026-06-23 17:26:49 +01:00
2026-05-30 21:37:47 +01:00
2026-06-16 01:41:15 +01:00
2026-06-02 23:48:54 +01:00
2026-05-13 10:07:50 -07:00
2026-06-03 00:08:03 +01:00
2026-05-22 13:22:51 +01:00
2026-07-01 11:14:48 +01:00
2026-07-09 23:32:54 +01:00
2026-07-08 12:09:40 +01:00
2026-07-08 01:14:12 +01:00
2026-05-22 13:22:51 +01:00
2026-06-11 15:08:36 -06:00
2026-07-01 15:09:42 +01:00
2026-05-17 11:32:38 +01:00
2026-07-06 12:42:39 +01:00
2026-07-02 22:29:30 +01:00
2026-07-08 16:38:35 +01:00
2026-07-02 22:29:29 +01:00
2026-05-12 02:23:51 +03:00
2026-06-07 14:34:13 +01:00
2026-07-01 11:52:50 +01:00
2026-04-06 16:06:31 +01:00
2026-07-01 10:49:43 +01:00
2026-06-30 18:30:05 +01:00
2026-06-02 22:23:15 +01:00
2026-07-08 01:16:58 +01:00
2026-07-02 23:25:54 +01:00
2026-06-30 19:32:10 +01:00
2026-06-11 19:52:56 +03:00
2026-07-01 10:47:10 +01:00
2026-07-09 01:06:02 +01:00
2026-05-26 09:17:18 +01:00
2026-06-26 10:23:10 +01:00
2026-06-30 11:19:54 +01:00
2026-07-09 01:06:02 +01:00
2026-06-28 16:17:21 +01:00
2026-07-08 17:07:31 +01:00
2026-07-08 01:21:55 +01:00
2026-06-28 16:57:00 +01:00
2026-07-09 13:22:36 +01:00
2026-06-07 15:03:49 +03:00
2026-06-28 16:57:00 +01:00
2026-06-18 01:55:56 +01:00
2026-07-06 16:43:21 +01:00
2026-06-11 09:36:38 +02:00
2026-05-07 20:07:57 +01:00
2026-07-06 16:49:31 +01:00
2026-07-02 11:50:12 +01:00
2026-06-30 16:58:23 +01:00
2026-06-18 22:55:44 +01:00
2026-07-02 22:29:32 +01:00
2026-05-05 00:07:50 +02:00
2026-06-28 19:29:51 +01:00
2026-06-30 23:26:13 +01:00
2026-07-01 10:30:47 +01:00
2026-07-01 11:43:05 +01:00
2026-06-24 11:43:13 +01:00
2026-06-13 15:13:23 +01:00
2026-06-02 20:48:13 +01:00
2026-07-06 16:43:21 +01:00
2026-07-06 16:38:42 +01:00
2026-07-06 16:38:42 +01:00
2026-07-09 10:44:50 +01:00
2026-07-05 10:42:09 +01:00
2026-06-18 22:50:52 +01:00
2026-07-06 12:46:12 +01:00
2026-06-29 09:40:22 +01:00
2026-07-08 22:49:01 +01:00
2026-07-06 16:02:45 +01:00
2026-07-02 22:29:30 +01:00
2026-07-04 22:12:47 +01:00
2026-06-19 10:25:09 +01:00
2026-05-26 20:16:41 +01:00
2026-07-08 12:45:08 +01:00
2026-06-10 15:50:38 +01:00
2026-05-22 13:22:51 +01:00
2026-05-22 13:22:51 +01:00
2026-07-01 13:45:53 +01:00
2026-07-03 18:34:41 +01:00
2026-05-31 16:41:18 +01:00
2026-07-04 22:12:47 +01:00
2026-06-02 22:50:33 +01:00
2026-07-06 12:44:47 +01:00
2026-06-02 22:50:33 +01:00
2026-06-16 01:41:15 +01:00
2026-07-09 00:32:21 +01:00
2026-07-09 00:32:21 +01:00
2026-07-09 01:06:02 +01:00
2026-05-13 23:19:15 +01:00
2026-06-30 16:59:16 +01:00
2026-07-05 10:42:09 +01:00
2026-07-04 21:22:39 +01:00
2026-07-04 03:12:23 +01:00
2026-04-15 23:08:43 +01:00
2026-06-02 22:16:58 +01:00
2026-05-16 22:36:58 +01:00
2026-05-24 20:38:10 +01:00
2026-05-22 13:22:51 +01:00
2026-06-03 21:04:01 +01:00
2026-07-06 00:45:51 +01:00
2026-07-06 16:38:42 +01:00
2026-06-30 12:57:33 +01:00
2026-07-06 12:36:12 +01:00
2026-07-07 10:57:52 +01:00
2026-07-05 11:41:18 +01:00
2026-05-22 13:22:51 +01:00
2026-07-06 16:38:42 +01:00
2026-07-08 01:03:28 +01:00
2026-06-30 16:58:23 +01:00
2026-07-04 03:12:23 +01:00
2026-07-03 00:32:24 +01:00
2026-04-06 16:06:31 +01:00
2026-07-02 12:11:51 +01:00
2026-07-08 23:56:28 +01:00
2026-06-30 23:15:52 +01:00
2026-07-04 22:43:31 +01:00
2026-07-02 11:46:22 +01:00
2026-06-16 03:06:43 +01:00
2026-06-30 16:59:16 +01:00
2026-06-05 21:46:25 +01:00
2026-04-10 15:55:22 +01:00
2026-07-02 22:38:29 +01:00
2026-07-02 22:38:28 +01:00
2026-07-04 03:12:23 +01:00
2026-05-31 16:47:52 +01:00
2026-07-02 22:38:29 +01:00
2026-07-03 16:03:18 +01:00
2026-07-02 22:29:31 +01:00
2026-06-24 08:54:11 +01:00
2026-06-26 10:20:53 +01:00
2026-07-08 01:08:02 +01:00
2026-06-23 17:26:49 +01:00
2026-06-27 10:19:15 +01:00
2026-07-04 22:12:47 +01:00
2026-07-05 10:33:07 +01:00