fix(extract): make the partial-parse warning actionable, and stop citing closed #2551 (#2788)

The partial-parse warning ended every message with a hardcoded (#2551) — a Kotlin-specific
issue that is now closed — which misdirected reporters into recording unrelated failures as
already-tracked. Drop the citation and append real per-file data instead: the surviving
symbol count, distinguishing a total-loss file from a partially-recovered one.
This commit is contained in:
abhay-codes07
2026-08-19 14:05:58 +01:00
committed by safishamsi
parent e4b85d3b50
commit 4f104e6e1f
2 changed files with 103 additions and 4 deletions
+21 -4
View File
@@ -5630,19 +5630,36 @@ def extract(
# results, so those fall back to the file-node-only arm.
if len(_res.get("nodes", [])) <= 1 or _pe.get("multiline_error"):
_rel = os.path.relpath(str(_p), str(root)).replace("\\", "/")
_syntax_error_files.append((_rel, _pe.get("first_error_line")))
# Symbols recovered from the file, excluding its own file node. This
# is what separates the two cases the warning otherwise blurs: a file
# that contributed nothing but its file node is a total loss, while
# one that yielded most of its symbols and lost an ERROR region is
# partial. "May be partially extracted" rendered both identically.
_kept = max(len(_res.get("nodes", [])) - 1, 0)
_syntax_error_files.append((_rel, _pe.get("first_error_line"), _kept))
if _syntax_error_files:
def _describe_syntax_error(rel: str, line: "int | None", kept: int) -> str:
_where = f"first error at line {line}" if line else "syntax error"
_got = "no symbols extracted" if kept == 0 else f"{kept} symbol(s) extracted"
return f"{rel} ({_where}, {_got})"
_shown = ", ".join(
f"{x} (first error at line {ln})" if ln else x
for x, ln in _syntax_error_files[:5]
_describe_syntax_error(*f) for f in _syntax_error_files[:5]
)
_more = (
f" (+{len(_syntax_error_files) - 5} more)"
if len(_syntax_error_files) > 5 else ""
)
# No issue reference here. This message used to end in "(#2551)" for
# EVERY language, and #2551 is closed and Kotlin-specific ("bundled
# grammar rejects one-line type bodies"). It was the only lead the
# message offered, so a reader following it landed on a resolved problem
# in another language and concluded their own was already tracked
# (#2788). The file, the line and the symbol count are the actionable
# part; a single hardcoded number cannot be right for every grammar.
print(
f" warning: {len(_syntax_error_files)} file(s) had syntax errors and "
f"may be partially extracted: {_shown}{_more} (#2551)",
f"may be partially extracted: {_shown}{_more}",
file=sys.stderr, flush=True,
)
+82
View File
@@ -0,0 +1,82 @@
"""The partial-extraction warning must be actionable and must not misdirect.
It used to end in a hardcoded `(#2551)` for EVERY language. #2551 is closed and
Kotlin-specific ("bundled grammar rejects one-line type bodies"), so a reader
following the only lead the message offered landed on a resolved problem in a
different language — and at least one did, recording an Astro failure as
"already tracked upstream" on the strength of that number (#2788).
The message also could not distinguish a file that contributed nothing but its
own file node from one that yielded most of its symbols and lost an ERROR
region. Both rendered as "may be partially extracted".
Part 1 of #2788 — the Astro frontmatter parse itself — is NOT addressed here;
that belongs to the .svelte/.astro AST work in #2731.
"""
import re
import pytest
from graphify.extract import extract
# Any hardcoded issue citation, not just 2551 — re-introducing a different
# number for a message that covers every grammar is the same mistake.
_ISSUE_CITATION = re.compile(r"\(#\d+\)")
def _partial_parse_fixture(tmp_path):
"""A file the parser ACCEPTS only through ERROR recovery — an unclosed table
constructor swallowing the function that follows it.
Deliberately not the Kotlin one-line body from #2551: whether that shape
trips the gate depends on the bundled grammar build, and these tests are
about the MESSAGE, which must read the same whichever grammar produced it.
"""
f = tmp_path / "broken.lua"
f.write_text("local t = {\nfunction f() end\n", encoding="utf-8")
return f
def _run(tmp_path, files, capsys):
extract([*files], root=tmp_path)
return capsys.readouterr().err
def test_warning_carries_no_hardcoded_issue_number(tmp_path, capsys):
err = _run(tmp_path, [_partial_parse_fixture(tmp_path)], capsys)
assert "partially extracted" in err, f"fixture no longer trips the gate: {err!r}"
assert not _ISSUE_CITATION.search(err), (
f"the warning still cites a single issue for every language: {err!r}")
assert "#2551" not in err
def test_warning_names_the_file_and_how_much_survived(tmp_path, capsys):
err = _run(tmp_path, [_partial_parse_fixture(tmp_path)], capsys)
assert "partially extracted" in err, err
assert "broken.lua" in err
assert ("no symbols extracted" in err
or re.search(r"\d+ symbol\(s\) extracted", err)), (
f"the warning does not say how much survived: {err!r}")
def test_warning_still_reports_the_first_error_line(tmp_path, capsys):
"""The line number was the one actionable thing the old message had; it must
survive the rewrite."""
err = _run(tmp_path, [_partial_parse_fixture(tmp_path)], capsys)
assert re.search(r"first error at line \d+", err), err
def test_a_clean_file_is_silent(tmp_path, capsys):
f = tmp_path / "fine.py"
f.write_text("def ok():\n return 1\n", encoding="utf-8")
err = _run(tmp_path, [f], capsys)
assert "partially extracted" not in err
assert "syntax errors" not in err
def test_the_citation_is_gone_from_the_source_not_just_one_path():
import graphify.extract as ex
text = open(ex.__file__, encoding="utf-8").read()
assert "may be partially extracted: {_shown}{_more} (#2551)" not in text
assert "no symbols extracted" in text
assert "symbol(s) extracted" in text